[webkit-reviews] review granted: [Bug 111780] Check to ensure MultisampleRenderbuffer creation succeeds : [Attachment 193187] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Brandon Jones
<bajones at chromium.org>'s request for review:
Bug 111780: Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Attachment 193187: Patch
https://bugs.webkit.org/attachment.cgi?id=193187&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193187&action=review


Looks fine modulo the ChangeLog entry.

>>> Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp:202
>>> +	 m_context->colorMask(true, true, true, true);
>> 
>> Don't you also need to restore the user's color mask afterward?
> 
> If so then we're already broken. reset() does the same thing (Line 342)
without ever restoring it. Perhaps this is a bug?

Looking again, WebGLRenderingContext::restoreStateAfterClear resets the color
mask, so this is OK.