[webkit-reviews] review granted: [Bug 112213] Character orientation should follow UTR50 specs for vertical layout : [Attachment 192841] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 112213: Character orientation should follow UTR50 specs for vertical layout
https://bugs.webkit.org/show_bug.cgi?id=112213

Attachment 192841: Patch
https://bugs.webkit.org/attachment.cgi?id=192841&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192841&action=review


I trust you that you've updated the table correctly. Please add the new pixel
results before you land.

> Source/WebCore/platform/graphics/FontFastPath.cpp:-47
> -    switch (character) {

I'm concerned that this might regress performance but I guess we can land and
see if it does.

> Source/WebCore/platform/graphics/FontFastPath.cpp:53
> +    if (character >= 0x002E5 && character <= 0x002EB)

Maybe we can add a helper function like isInRange so that we can write this
like isInRange(character, 0x002E5, 0x002EB)

> Source/WebCore/platform/graphics/mac/FontMac.mm:101
> +	   CGAffineTransform savedMatrix;

I wich this entire block were broken up into smaller inline functions but that
can be done in a separate patch.

> Source/WebCore/platform/graphics/mac/FontMac.mm:115
> +	   } else {
> +	       translationsTransform = rotateLeftTransform;
> +	   }

Nit: no curly brackets around a single line statement as you pointed out in
person.