[webkit-reviews] review granted: [Bug 100299] [CSS Exclusions] shape-outside on floats for rounded rectangle shapes : [Attachment 193155] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 13:48:48 PDT 2013


Dirk Schulze <krit at webkit.org> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 100299: [CSS Exclusions] shape-outside on floats for rounded rectangle
shapes
https://bugs.webkit.org/show_bug.cgi?id=100299

Attachment 193155: Patch
https://bugs.webkit.org/attachment.cgi?id=193155&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193155&action=review


r=me

> LayoutTests/fast/exclusions/resources/rounded-rectangle.js:172
> +    if (floatValue == "right") {
> +	   dimensions.shapeX = -dimensions.shapeWidth;
> +    }

The braces are not necessary here.


More information about the webkit-reviews mailing list