[webkit-reviews] review denied: [Bug 112353] Web Inspector: Make Source Frame & status bar a layout boundary : [Attachment 193129] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 112353: Web Inspector: Make Source Frame & status bar a layout boundary
https://bugs.webkit.org/show_bug.cgi?id=112353

Attachment 193129: Patch
https://bugs.webkit.org/attachment.cgi?id=193129&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193129&action=review


> Source/WebCore/inspector/front-end/SourceFrame.js:697
> +	   this.element.style.height = this.element.parentElement.offsetHeight
+ "px";

We could do this for all views that use "fill" style. I.e. we make all views
have a "view" classname and for  ".view .fill" we make it a boundary. "fill"
guarantees absolute positioning, so .view .fill would need to add width: 100%,
overflow and you take care of the height here. So you magically fix everything
at once.

> Source/WebCore/inspector/front-end/inspector.css:53
> +    /* position must be relative or absolute */

You could set position: relative here since it is not affecting the layout by
default. And you could specify the height of 300px so that clients were forced
to override it.