[webkit-reviews] review denied: [Bug 112276] Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue : [Attachment 193169] patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 12:22:01 PDT 2013


chris fleizach <cfleizach at apple.com> has denied  review:
Bug 112276: Allow multiple searchKeys to be passed to
AXUIElementCopyParameterizedAttributeValue
https://bugs.webkit.org/show_bug.cgi?id=112276

Attachment 193169: patch v4
https://bugs.webkit.org/attachment.cgi?id=193169&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193169&action=review


overall looks good, but change log isn't correct and you need a layout test

> Source/WebCore/ChangeLog:3
> +	   Allow multiple searchKeys to be passed to
AXUIElementCopyParameterizedAttributeValue

please use prepare-Changelog --bug=X to make the appropriate change log
then check other change log entries


More information about the webkit-reviews mailing list