[webkit-reviews] review granted: [Bug 109712] [Chromium] Compositor is applying scroll offset using 'programmatic' API : [Attachment 193120] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 109712: [Chromium] Compositor is applying scroll offset using
'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Attachment 193120: Patch
https://bugs.webkit.org/attachment.cgi?id=193120&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193120&action=review


R=me

>>> Source/WebKit/chromium/src/WebViewImpl.cpp:3010
>>> +	     if (!page()->settings()->applyPageScaleFactorInCompositor())
>> 
>> This setting is always true in Chromium now anyway, so you can delete this.
> 
> I would prefer to keep it for now, as many of our unit tests (e.g.
WebViewTest.ResetScrollAndScaleState) are running without this flag. I think it
would be better to do a single focused change on removing the setting entirely,
when the time is right. What do you think?

I think you should delete it. This code otherwise will be DOA