[webkit-reviews] review requested: [Bug 112311] autotools build: Automagic dependencies for libxslt and geoclue : [Attachment 193162] new patch enabling more automagic dependencies and raises warnings

[bugzilla-daemon at webkit.org]

Tobias Mueller <tobiasmue at gnome.org> has asked	for review:
Bug 112311: autotools build: Automagic dependencies for libxslt and geoclue
https://bugs.webkit.org/show_bug.cgi?id=112311

Attachment 193162: new patch enabling more automagic dependencies and raises
warnings
https://bugs.webkit.org/attachment.cgi?id=193162&action=review

------- Additional Comments from Tobias Mueller <tobiasmue at gnome.org>
(In reply to comment #4)
> This makes me sad, since I've spent a lot of time trying to make it easier to
build and test WebKit.
Having WebKit shipping a jhbuild setup that runs all by itself is a huge
benefit. That's very good.
> Did you run Tools/gtk/install-dependencies first?
No. I got my Fedora machine to compile. That was almost easy. It passed the
configure step and then broke at some stage during compilation, because I
disabled every optional dependency, hoping to make it build faster ;-) But
apparently, that's not very well tested. (I suffered from bug 112033, filed bug
111862 and bug 112368)
But it's very slow and I can't use my machine while it's compiling. So I looked
around for a bigger machine that I could use. I found an OpenSuSE from two
years ago. It doesn't have things like the mandatory GCC 4.7 (released 1 year
ago). So not only am I not on Fedora or Debian, but also non root.

> So If not, is there somewhere we can put the instructions to make them more
prominent?
Hm. To be honest, I didn't know about install-dependencies and found the
bundled jhbuild much later. I came from http://webkitgtk.org/?page=contribute
and read both linked sites: http://webkitgtk.org/?page=download and
http://trac.webkit.org/wiki/HackingGtk. Neither mention the tools. So to
improve the experience for newcomers, it might be beneficial to mention the
available tools to bootstrap the build environment.

> If there were dependencies missing there, do you happen to remember any of
them so they can be added to Tools/gtk/install-dependencies?
Here are the packages that I installed on top of the jhbuild environment that
WebKit ships but didn't : gnutls gcc libwebp icu libxslt sqlite libcroco
icon-naming-utils expat dbus pango and perf.
If you think it's worth supporting a non-root, one year old building platform
such as the OpenSuSE I have, I can prepare a patch of the optional moduleset
and post it here, but probably in a new bug. If you say it's not worth it, I'll
keep it as a dark secret for myself ;-)


But let's come back to the automagic dependencies.
I enabled more dependencies to be auto checked, namely gstreamer and enchant
and supplied warnings for both, as they were enabled by default.