[webkit-reviews] review denied: [Bug 111670] Implement pinch zoom for bottom-right fixed-position elements : [Attachment 191901] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 111670: Implement pinch zoom for bottom-right fixed-position elements
https://bugs.webkit.org/show_bug.cgi?id=111670

Attachment 191901: Patch
https://bugs.webkit.org/attachment.cgi?id=191901&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191901&action=review


Looks like you have a few refinements you plan to do with this patch.

>>> Source/Platform/chromium/public/WebLayer.h:199
>>> +	 virtual void setFixedToRightEdge(bool) { }
>> 
>> I wonder if we should have something more like the bitfields in the
ViewportConstraints instead of this? That'll also cover cases where a layer is
fixed to both edges on the same axis, in which case we may want to do something
special in the compositor.
> 
> I think you're right. I was too lazy to write a WebViewportConstraint. Will
do.

Still waiting for this.

Also, do we need right-anchored right now?  I think the immediate need is just
for bottom-anchored, isn't it?	We can add right-anchored later.