[webkit-reviews] review granted: [Bug 112337] Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel. : [Attachment 193099] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 14 05:30:41 PDT 2013
Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 112337: Web Inspector: Flame Chart. Support scroll and zoom with help of
mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=112337
Attachment 193099: Patch
https://bugs.webkit.org/attachment.cgi?id=193099&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193099&action=review
> Source/WebCore/inspector/front-end/FlameChart.js:224
> + this._xScaleFactor = --this._xScaleFactor > minXScaleFactor ?
this._xScaleFactor : minXScaleFactor;
if (--this._xScaleFactor < minScaleFactor)
this._xScaleFactor = minScaleFactor;
Also this._xScaleFactor is a floating point number, should it be int?
More information about the webkit-reviews
mailing list