[webkit-reviews] review denied: [Bug 112338] Web Inspector: [DataGrid] Specify columns with array of descriptors. : [Attachment 193100] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 112338: Web Inspector: [DataGrid] Specify columns with array of
descriptors.
https://bugs.webkit.org/show_bug.cgi?id=112338

Attachment 193100: Patch
https://bugs.webkit.org/attachment.cgi?id=193100&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193100&action=review


> Source/WebCore/inspector/front-end/DataGrid.js:29
> + * @param {!Array.<!WebInspector.DataGrid.ColumnDescriptor>} columns

Lets name it columnsArray

> Source/WebCore/inspector/front-end/DataGrid.js:84
> +	   column.ordinal = i;

Why do you need ordinals now?

> Source/WebCore/inspector/front-end/DataGrid.js:-117
> -    columnGroup.span = this._columnCount;

Where did this go?

> Source/WebCore/inspector/front-end/DataGrid.js:-125
> -    var fillerRow = document.createElement("tr");

Where did this go?