[webkit-reviews] review requested: [Bug 111733] [BlackBerry] Prevent text selection inside Colour and Date/Time input fields : [Attachment 193105] Fix compilation error
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 14 04:30:37 PDT 2013
Alberto Garcia <agarcia at igalia.com> has asked for review:
Bug 111733: [BlackBerry] Prevent text selection inside Colour and Date/Time
input fields
https://bugs.webkit.org/show_bug.cgi?id=111733
Attachment 193105: Fix compilation error
https://bugs.webkit.org/attachment.cgi?id=193105&action=review
------- Additional Comments from Alberto Garcia <agarcia at igalia.com>
+ if (Node* focusedNode = frame->document()->focusedNode()
+ && (focusedNode->hasTagName(HTMLNames::selectTag) ||
(focusedNode->isElementNode() &&
DOMSupport::isPopupInputField(toElement(focusedNode))))) {
+ SelectionLog(Platform::LogLevelInfo,
"SelectionHandler::selectionPositionChanged selection is on a popup control,
skipping rendering.");
+ return;
+ }
+ }
Uh, oh, there's one brace missing, this won't compile.
More information about the webkit-reviews
mailing list