[webkit-reviews] review granted: [Bug 112264] Web Inspector: Flame Chart. Rewrite drawing procedure for better performance. : [Attachment 192936] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 112264: Web Inspector: Flame Chart. Rewrite drawing procedure for better
performance.
https://bugs.webkit.org/show_bug.cgi?id=112264

Attachment 192936: Patch
https://bugs.webkit.org/attachment.cgi?id=192936&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192936&action=review


> Source/WebCore/inspector/front-end/FlameChart.js:87
> +	   var startTimes = new Float32Array(nodeCount);

Does it make any difference compared to new Array(nodeCount) ?

> Source/WebCore/inspector/front-end/FlameChart.js:94
> +	   function appendReversedArray(toArray, fromArray) {

style: { on next line.