[webkit-reviews] review granted: [Bug 112296] Replace static_casts with to* functions - Part 4 : [Attachment 193059] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 13 21:23:21 PDT 2013
Kentaro Hara <haraken at chromium.org> has granted Abhishek Arya
<inferno at chromium.org>'s request for review:
Bug 112296: Replace static_casts with to* functions - Part 4
https://bugs.webkit.org/show_bug.cgi?id=112296
Attachment 193059: Patch
https://bugs.webkit.org/attachment.cgi?id=193059&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193059&action=review
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1045
> + if (!node || !node->isElementNode())
Should we have the '!node->isElementNode()' check, or should we add
ASSERT(node->isElementNode()) ?
(I am asking this just because you are introducing the check in this patch.)
> Source/WebCore/page/DragController.cpp:788
> + Image* image = node->isElementNode() ? getImage(toElement(node)) : 0;
Ditto.
More information about the webkit-reviews
mailing list