[webkit-reviews] review granted: [Bug 110728] [EFL][WK2] Add an API for adding and removing user style sheets from a page group : [Attachment 192613] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 13 20:40:38 PDT 2013
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 110728: [EFL][WK2] Add an API for adding and removing user style sheets
from a page group
https://bugs.webkit.org/show_bug.cgi?id=110728
Attachment 192613: Patch
https://bugs.webkit.org/attachment.cgi?id=192613&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192613&action=review
LGTM. Signed off by Benjamin for WK2.
> Source/WebKit2/PlatformEfl.cmake:173
> + "${WEBKIT2_DIR}/Shared/API/c/efl"
Wrong alphabet order.
> Source/WebKit2/UIProcess/API/efl/ewk_page_group.h:35
> +#include <Evas.h>
It looks this is not needed here.
More information about the webkit-reviews
mailing list