[webkit-reviews] review requested: [Bug 112311] autotools build: Automagic dependencies for libxslt and geoclue : [Attachment 193038] Patch to automagically detect some dependencies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 19:30:30 PDT 2013


Tobias Mueller <tobiasmue at gnome.org> has asked	for review:
Bug 112311: autotools build: Automagic dependencies for libxslt and geoclue
https://bugs.webkit.org/show_bug.cgi?id=112311

Attachment 193038: Patch to automagically detect some dependencies
https://bugs.webkit.org/attachment.cgi?id=193038&action=review

------- Additional Comments from Tobias Mueller <tobiasmue at gnome.org>
Currently, running ./configure without arguments enables many things by
default, regardless whether the environment actually supports the things or
not. I.e. libxslt or geoclue. So it would simple fail to configure on a machine
which does not have libxslt and one would have to manually configure
--disable-xslt.

With the patch attached, dependencies are automagically detected. User's choice
has precedence. So if a user did ./configure --enable-xslt the configure will
fail if libxslt is not present. However, if the user does calls ./configure
with neither --enable-xslt nor --disable-xslt, the presence of libxslt is
detected and if it exists, enabled.


More information about the webkit-reviews mailing list