[webkit-reviews] review denied: [Bug 112301] Add support for MediaSource::isTypeSupported() : [Attachment 193024] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 112301: Add support for MediaSource::isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=112301

Attachment 193024: Patch
https://bugs.webkit.org/attachment.cgi?id=193024&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193024&action=review


We usually put MIME-type related queries on WebMIMERegistry.  However, I notice
that this is not a function on WebCore::MIMERegistry, although I suppose it
could be.


> Source/WebKit/chromium/src/MediaSourcePrivateImpl.cpp:46
> +    return
WebKit::webKitPlatformSupport()->isTypeSupportedForMediaSource(type, codecs);

nit: webKitPlatformSupport() is deprecated.  You should be using
WebKit::Platform::current() instead.