[webkit-reviews] review denied: [Bug 112275] TextIterator emits LF for a br element inside an empty input element : [Attachment 193011] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Aurimas Liutikas
<aurimas at chromium.org>'s request for review:
Bug 112275: TextIterator emits LF for a br element inside an empty input
element
https://bugs.webkit.org/show_bug.cgi?id=112275

Attachment 193011: Patch
https://bugs.webkit.org/attachment.cgi?id=193011&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193011&action=review


Look at tests inside LayoutTests/editing/text-iterator.

> Source/WebCore/editing/TextIterator.cpp:756
> +	   return node->hasTagName(brTag) && !node->isInShadowTree() &&
!node->shadowHost()->toInputElement();

This is wrong. Being inside a shadow tree doesn't imply that the shadow tree is
inside an input element.

>> Source/WebCore/editing/TextIterator.cpp:758
>>	return r->isBR();
> 
> Should I do a similar check here using node? I am not familiar what
RenderObject means.

Yes. Having a renderer means that the node nor its ancestors don't have
display: none.