[webkit-reviews] review granted: [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page : [Attachment 192999] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 109404: Add selectTrailingWhitespaceEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=109404

Attachment 192999: Patch
https://bugs.webkit.org/attachment.cgi?id=192999&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192999&action=review


r=me provided the following comments are addressed.

> Source/WebKit/mac/WebView/WebView.mm:789
> +	  
_private->page->settings()->setSmartInsertDeleteEnabled(smartInsertDeleteEnable
d);
> +	  
_private->page->settings()->setSelectTrailingWhitespaceEnabled(!smartInsertDele
teEnabled);

Why don't we call [self setSelectTrailingWhitespaceEnabled] here.

> Source/WebKit/mac/WebView/WebView.mm:2481
> +	   // Set smartInsertDeleteEnabled as they are mutually exclusive.

I don't think this and similar comments are useful as the code clearly
indicates they're mutually exclusive already. Please remove them.