[webkit-reviews] review denied: [Bug 112278] [BlackBerry] Add Proximity Detector. : [Attachment 192975] Patch with changelogs - style fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 13:09:33 PDT 2013


Rob Buis <rwlbuis at gmail.com> has denied gmak at rim.com's request for review:
Bug 112278: [BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278

Attachment 192975: Patch with changelogs - style fixed
https://bugs.webkit.org/attachment.cgi?id=192975&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192975&action=review


Can be cleaned up a bit more.

> Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp:18
> +using WTF::RefPtr;

Should not be needed at all.

> Source/WebKit/blackberry/WebKitSupport/ProximityDetector.cpp:19
> +using WTF::String;

You may get away with discarding this one but it depends if it clashes with
B::P::String.


More information about the webkit-reviews mailing list