[webkit-reviews] review granted: [Bug 110263] Add the default video poster if it doesn't exist in video tag : [Attachment 192945] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 12:56:28 PDT 2013


Darin Adler <darin at apple.com> has granted michaelbai at chromium.org's request for
review:
Bug 110263: Add the default video poster if it doesn't exist in video tag
https://bugs.webkit.org/show_bug.cgi?id=110263

Attachment 192945: Patch
https://bugs.webkit.org/attachment.cgi?id=192945&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192945&action=review


> Source/WebCore/html/HTMLVideoElement.cpp:188
> +    if (!stripLeadingAndTrailingHTMLSpaces(url).isEmpty())

Some day we may want to replace this by an isAllHTMLSpaces function that does
not require copying the string even if the string contains leading or trailing
spaces.

> Source/WebCore/html/HTMLVideoElement.h:72
> +    const KURL posterImageURL();

The const here before KURL is unneeded and nearly meaningless. It just means
that you can’t call non-const member functions on the return value from this
function.

What I meant when I said that this function should be const is that there
should be a const *after* the parentheses, allowing this to be called on a
const HTMLVideoElement.


More information about the webkit-reviews mailing list