[webkit-reviews] review denied: [Bug 112276] Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue : [Attachment 192964] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 12:55:04 PDT 2013


chris fleizach <cfleizach at apple.com> has denied  review:
Bug 112276: Allow multiple searchKeys to be passed to
AXUIElementCopyParameterizedAttributeValue
https://bugs.webkit.org/show_bug.cgi?id=112276

Attachment 192964: patch
https://bugs.webkit.org/attachment.cgi?id=192964&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192964&action=review


> Source/WebCore/accessibility/AccessibilityObject.cpp:121
> +    unsigned length = criteria->searchKeys->size();

my guess is that size() is a size_t object

> Source/WebCore/accessibility/AccessibilityObject.cpp:124
> +	   switch (criteria->searchKeys->at(i)) {

all these changes here are unnecessary and they'll fail the style guidelines

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3187
> +	   if ([searchKeyEntry isKindOfClass:[NSString self]])

[NSString class]

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3189
> +	   else if ([searchKeyEntry isKindOfClass:[NSArray self]]) {

[NSArray class]

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3190
> +	       unsigned length = [(NSArray *)searchKeyEntry count];

i believe count is a NSUInteger

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3192
> +	       for (unsigned i = 0; i < length; ++i) {

size length is NSUInteger, so should i

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3194
> +		   if ([searchKey isKindOfClass:[NSString self]])

[NSString class]


More information about the webkit-reviews mailing list