[webkit-reviews] review denied: [Bug 111074] REGRESSION(r141450): failed ASSERT in FrameView::scheduleRelayout() : [Attachment 192962] Alternative patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 111074: REGRESSION(r141450): failed ASSERT in FrameView::scheduleRelayout()
https://bugs.webkit.org/show_bug.cgi?id=111074

Attachment 192962: Alternative patch
https://bugs.webkit.org/attachment.cgi?id=192962&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192962&action=review


> Source/WebCore/ChangeLog:11
> +	   Update RenderView so it retrieves the FrameView from the Document
instead
> +	   of storing it as a member upon construction. This makes sure that
the
> +	   FrameView returned by the RenderView always matches the one of the
> +	   Document.

But this implies that the RenderView can retrieve a different FrameView at
different times, which is totally unexpected. I think this change is just
papering over the cracks. We need to understand why the wrong FrameView is
retrieved when the assertion happens.