[webkit-reviews] review granted: [Bug 112047] Regression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra bottom padding : [Attachment 192844] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 112047: Regression(r143542): -webkit-align-items: center with overflow:
auto/scroll has extra bottom padding
https://bugs.webkit.org/show_bug.cgi?id=112047

Attachment 192844: Patch
https://bugs.webkit.org/attachment.cgi?id=192844&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192844&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:442
> +	   if (child->isOutOfFlowPositioned())
> +	       continue;

Maybe add a test-case with out of flow positioned children? Or does one of the
existing test cases already cover this?

> Source/WebCore/rendering/RenderFlexibleBox.cpp:444
> +	   LayoutUnit childLogicalBottom = logicalTopForChild(child) +
logicalHeightForChild(child) + marginAfterForChild(child);
> +	   maxChildLogicalBottom = std::max(maxChildLogicalBottom,
childLogicalBottom);

Technically, we only need to do this if the child is aligned center or
flex-end, but I suppose it's not worth the extra code.