[webkit-reviews] review granted: [Bug 112271] Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation : [Attachment 192949] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 11:14:21 PDT 2013


Tim Horton <timothy_horton at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 112271: Calling WebInspectorClient::highlight() during a fade-out animation
of the PageOverlay won't stop its animation
https://bugs.webkit.org/show_bug.cgi?id=112271

Attachment 192949: Patch
https://bugs.webkit.org/attachment.cgi?id=192949&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192949&action=review


> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:158
> +    m_fadeAnimationTimer.stop();

Should you reset m_fractionFadedIn to ... something?


More information about the webkit-reviews mailing list