[webkit-reviews] review granted: [Bug 112184] [EFL] Better error handling in NetworkStateNotifierEfl : [Attachment 192873] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 112184: [EFL] Better error handling in NetworkStateNotifierEfl
https://bugs.webkit.org/show_bug.cgi?id=112184

Attachment 192873: Patch
https://bugs.webkit.org/attachment.cgi?id=192873&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192873&action=review


> Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:112
> +    while (1) {

isnt while (true) not more readable?

> Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:113
> +	   ssize_t len = recv(sock, nlh, bufferSize, MSG_DONTWAIT);

length?