[webkit-reviews] review denied: [Bug 112138] Web Inspector: [CodeMirror] add smart braces functionality : [Attachment 192733] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 112138: Web Inspector: [CodeMirror] add smart braces functionality
https://bugs.webkit.org/show_bug.cgi?id=112138

Attachment 192733: Patch
https://bugs.webkit.org/attachment.cgi?id=192733&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192733&action=review


> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:68
> +    this._smartBracesController = new
WebInspector.CodeMirrorTextEditor.SmartBracesController(this._codeMirror);

Please move this behind a setting

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:515
> +	       if (WebInspector.TextUtils.isWordChar(char) ||
(!WebInspector.TextUtils.isBraceChar(char) &&
WebInspector.TextUtils.isStopChar(char)))

if (!whitespace && !clsoingBrace) ?