[webkit-reviews] review denied: [Bug 112153] Web Inspector: [CodeMirror] Handle "enter" key in {|} situation : [Attachment 192735] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 05:07:19 PDT 2013


Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 112153: Web Inspector: [CodeMirror] Handle "enter" key in {|} situation
https://bugs.webkit.org/show_bug.cgi?id=112153

Attachment 192735: Patch
https://bugs.webkit.org/attachment.cgi?id=192735&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192735&action=review


> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:493
> +	   if (line.substr(cursor.ch - 1, 2) === "{}") {

You should if the selection range is empty here.


More information about the webkit-reviews mailing list