[webkit-reviews] review granted: [Bug 112144] [Qt] Prepare DRT for transition to shared TestRunner interface : [Attachment 192739] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 112144: [Qt] Prepare DRT for transition to shared TestRunner interface
https://bugs.webkit.org/show_bug.cgi?id=112144

Attachment 192739: Patch
https://bugs.webkit.org/attachment.cgi?id=192739&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192739&action=review


> Tools/ChangeLog:16
> +	   This is impplemented by instantiating the QObject based testRunner
in
> +	   the global object, then instantiating the JSC C based TestRunner
> +	   separately and placing it "behind" the QObject based testRunner
through
> +	   injection in the prototype chain. This allows for porting over
method
> +	   by method by removing the method from the QObject TestRunnerQt and
> +	   implementing it in the JSC C based TestRunner.

Good idea!

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:982
> +
> +
> +
> +void TestRunner::notifyDone()

many spaces?

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1001
> +}
> +
> +
> +void TestRunner::removeAllWebNotificationPermissions()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1010
> +}
> +
> +
> +void TestRunner::closeIdleLocalStorageDatabases()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1015
> +}
> +
> +
> +void TestRunner::focusWebView()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1024
> +}
> +
> +
> +void TestRunner::removeChromeInputField()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1029
> +}
> +
> +
> +void TestRunner::addChromeInputField()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1034
> +}
> +
> +
> +JSValueRef TestRunner::originsWithLocalStorage(JSContextRef context)

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1048
> +
> +
> +void TestRunner::observeStorageTrackerNotifications(unsigned number)

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1057
> +}
> +
> +
> +int TestRunner::windowCount()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1063
> +}
> +
> +
> +void TestRunner::setWaitToDump(bool)

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1068
> +
> +
> +void TestRunner::waitForPolicyDelegate()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1078
> +}
> +
> +
> +void TestRunner::showWebInspector()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1091
> +}
> +
> +
> +void TestRunner::setSerializeHTTPLoads(bool)

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1100
> +}
> +
> +
> +void TestRunner::setCustomPolicyDelegate(bool setDelegate, bool permissive)

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1113
> +}
> +
> +
> +void TestRunner::resetPageVisibility()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1118
> +}
> +
> +
> +void TestRunner::keepWebHistory()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1123
> +}
> +
> +
> +void TestRunner::goBack()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1138
> +}
> +
> +
> +void TestRunner::display()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1143
> +}
> +
> +
> +void TestRunner::dispatchPendingLoadRequests()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1148
> +}
> +
> +
> +void TestRunner::clearPersistentUserStyleSheet()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1163
> +}
> +
> +
> +void TestRunner::clearBackForwardList()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1168
> +}
> +
> +
> +void TestRunner::clearAllDatabases()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1177
> +}
> +
> +
> +void TestRunner::apiTestGoToCurrentBackForwardItem()

Ditto.

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:1186
> +}
> +
> +
> +void TestRunner::abortModal()

Ditto.

Etc, etc.