[webkit-reviews] review granted: [Bug 112202] [iOS] Add optimized version of StringImpl's equal(LChar*, LChar*) for Apple CPUs : [Attachment 192836] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 112202: [iOS] Add optimized version of StringImpl's equal(LChar*,LChar*)
for Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112202

Attachment 192836: Patch
https://bugs.webkit.org/attachment.cgi?id=192836&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192836&action=review


Looks good!

> Source/WTF/wtf/text/StringImpl.h:933
> +	   "b	   66f\n"

I think you could invert this to:
-> "bneq 66f" "b 0b"

And if you then move the label "0:" down a line, you could branch past the cbz:

-> "bneq 66f" "cbnz 0b"

This would save an unconditional branch from the loop.
Don't know if this might help?