[webkit-reviews] review granted: [Bug 111701] Basic child obscuration test for backgrounds : [Attachment 192839] patch 6

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 111701: Basic child obscuration test for backgrounds
https://bugs.webkit.org/show_bug.cgi?id=111701

Attachment 192839: patch 6
https://bugs.webkit.org/attachment.cgi?id=192839&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192839&action=review


> Source/WebCore/rendering/RenderBox.cpp:1202
> +	       if (layer() && layer()->isStackingContext() &&
childLayer->zIndex() < layer()->zIndex())

This should be childLayer->zIndex() < 0.

> Source/WebCore/rendering/RenderBox.cpp:1204
> +	       if (childLayer->hasTransform() || childLayer->isTransparent() ||
childLayer->isSelfPaintingLayer())

I don't think you need to bail on childLayer->isSelfPaintingLayer()