[webkit-reviews] review denied: [Bug 112077] add memory sampler to Network Process : [Attachment 192594] patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 12 16:14:19 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has denied Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 112077: add memory sampler to Network Process
https://bugs.webkit.org/show_bug.cgi?id=112077
Attachment 192594: patch 2
https://bugs.webkit.org/attachment.cgi?id=192594&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192594&action=review
> Source/WebKit2/UIProcess/WebContext.cpp:996
> + // WebProcess is called in ProcessDidFinishLoading when we know the PID.
Please reword this to explain what's done with WebProcess there. Also, this
would me more visible next to NetworkProcess comment above.
> Source/WebKit2/UIProcess/WebContext.cpp:999
> void WebContext::stopMemorySampler()
This needs to be updated too.
More information about the webkit-reviews
mailing list