[webkit-reviews] review granted: [Bug 112198] Add a --build-dir argument to delete-stale-build-files : [Attachment 192824] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 112198: Add a --build-dir argument to delete-stale-build-files
https://bugs.webkit.org/show_bug.cgi?id=112198

Attachment 192824: patch
https://bugs.webkit.org/attachment.cgi?id=192824&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192824&action=review


> Tools/BuildSlaveSupport/delete-stale-build-files:35
> +    parser.add_option("--build-dir", dest="directory")

Could you instead use --build-directory to match run-webkit-tests?

> Tools/BuildSlaveSupport/delete-stale-build-files:53
> +	   directory = options.directory

I would have preferred to call this buildDirectory. If you rename the option
and omit "dest", it'll automatically do that.