[webkit-reviews] review granted: [Bug 112178] Make CheckedArithmetic slightly more sane : [Attachment 192789] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 112178: Make CheckedArithmetic slightly more sane
https://bugs.webkit.org/show_bug.cgi?id=112178

Attachment 192789: Patch
https://bugs.webkit.org/attachment.cgi?id=192789&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192789&action=review


r=me

> Source/WTF/wtf/CheckedArithmetic.h:73
> +    HasOverflowed,
> +    Safe

I think this would be clearer if the two states were called "DidOverflow" and
"DidNotOverflow". Whether something is "safe" is a value judgement this data
cannot make.