[webkit-reviews] review granted: [Bug 111802] Make all v8 weak callbacks type safe : [Attachment 192642] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 11:26:15 PDT 2013


Adam Barth <abarth at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 111802: Make all v8 weak callbacks type safe
https://bugs.webkit.org/show_bug.cgi?id=111802

Attachment 192642: Patch
https://bugs.webkit.org/attachment.cgi?id=192642&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192642&action=review


This is way better!

> Source/WebCore/bindings/v8/V8Utilities.h:67
> +    template<class OwnerType, typename ArgumentType = OwnerType>

Any reason why one of these arguments is "class" and the other "typename"?


More information about the webkit-reviews mailing list