[webkit-reviews] review granted: [Bug 111147] [chromium] Use lipo(1) rather than file(1) to list library architectures. : [Attachment 190894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 10:22:11 PDT 2013


Nico Weber <thakis at chromium.org> has granted Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 111147: [chromium] Use lipo(1) rather than file(1) to list library
architectures.
https://bugs.webkit.org/show_bug.cgi?id=111147

Attachment 190894: Patch
https://bugs.webkit.org/attachment.cgi?id=190894&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190894&action=review


>>> Source/WebCore/ChangeLog:6
>>> +	     Parsing file(1) output can be fragile; this patch replaces a use
of file(1) to get
>> 
>> Which problem are you seeing?
> 
> On my mac, I couldn't build Chromium. I have MacPorts, and the file(1)
installed with that had incompatible output, which made ARCHS not get loaded
correctly.
> 
> Since the script already uses lipo(1) later, and since it can output the data
that's being looked for, that seemed the way to go, rather than coding
/usr/bin/file or adding a more flexible parser of file(1)'s output.

Hm, ok. MacPorts breaks other stuff too (see e.g. the thread on chromium-dev
from yesterday night), but if you're happy with being on the hook if the output
of lipo varies over time, I can live with this :-)


More information about the webkit-reviews mailing list