[webkit-reviews] review denied: [Bug 111288] [GTK][WK2] Add webkit_web_page_get_uri to WebKit2 GTK+ API : [Attachment 191666] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 07:25:04 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 111288: [GTK][WK2] Add webkit_web_page_get_uri to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111288

Attachment 191666: Patch
https://bugs.webkit.org/attachment.cgi?id=191666&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191666&action=review


> Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp:320
> +	   g_signal_connect(m_webView, "notify::uri",
G_CALLBACK(webViewURIChanged), this);
> +    }

You should add a destructor to disconnect the signal and unsubscribe the dbus
signal too.


More information about the webkit-reviews mailing list