[webkit-reviews] review canceled: [Bug 112113] Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle Inspector window full-screen state : [Attachment 192721] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 07:10:53 PDT 2013


Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Eugene
Klyuchnikov <eustas at chromium.org>'s request for review:
Bug 112113: Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11)
shortcuts toggle Inspector window full-screen state
https://bugs.webkit.org/show_bug.cgi?id=112113

Attachment 192721: Patch
https://bugs.webkit.org/attachment.cgi?id=192721&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192721&action=review


Good, only a few JSDoc nits.

> Source/WebCore/inspector/front-end/CallStackSidebarPane.js:73
> +	*/

@return {boolean}

> Source/WebCore/inspector/front-end/CallStackSidebarPane.js:85
> +	*/

Ditto.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:772
> +	* @param {Event=} event

Is it here only for the frontend compilability?


More information about the webkit-reviews mailing list