[webkit-reviews] review denied: [Bug 112095] [Texmap] Synchronise layers only if the layer has been changed. : [Attachment 192714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 06:59:21 PDT 2013


Noam Rosenthal <noam at webkit.org> has denied JungJik Lee
<jungjik.lee at samsung.com>'s request for review:
Bug 112095: [Texmap] Synchronise layers only if the layer has been changed.
https://bugs.webkit.org/show_bug.cgi?id=112095

Attachment 192714: Patch
https://bugs.webkit.org/attachment.cgi?id=192714&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
This is actually wrong. We might have a m_movingVisibleRect and still not need
to sync. This patch would make it so that during a transform animation we'd be
constantly syncing.
The right approach for this is close to what ryumiel was suggesting - add an
isEmpty() function to GraphicsLayerState and not sync if that returns true.


More information about the webkit-reviews mailing list