[webkit-reviews] review denied: [Bug 111688] Web Inspector: Details of InjectedScript function call shall not be linkified in Timeline panel. : [Attachment 192652] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has denied pdeng6
<pan.deng at intel.com>'s request for review:
Bug 111688: Web Inspector: Details of InjectedScript function call shall not be
linkified in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=111688

Attachment 192652: Patch
https://bugs.webkit.org/attachment.cgi?id=192652&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192652&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1127
> +	* @return {true|false}

{boolean}

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1133
> +		   var parsedURL = new WebInspector.ParsedURL(this.scriptName);


You can make use of String.prototype.asParsedURL found in ParsedURL.js and
rewrite this as:

this._validScriptLocation = !!this.scriptName.asParsedURL();

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1135
> +	       } else {

Please remove curly braces around a single-line block.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1140
> +	   return  this._validScriptLocation;

Extraneous whitespace after "return"