[webkit-reviews] review granted: [Bug 112123] Web Inspector: add html canvas memory details to the native memory overview : [Attachment 192687] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 112123: Web Inspector: add html canvas memory details to the native memory
overview
https://bugs.webkit.org/show_bug.cgi?id=112123

Attachment 192687: Patch
https://bugs.webkit.org/attachment.cgi?id=192687&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192687&action=review


> Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:82
> +	   var canvases = aggregatesByClassName["WebCore::HTMLCanvasElement"];

Please add a blank line above to separate the two types of "images".

> Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:85
> +	       return "HTMLCanvasElement";

node.name() above returns something akin to "IMG", which is an HTML name of the
tag, as opposed to "HTMLCanvasElement", which is a DOM type name. Inconsistency
ensues.