[webkit-reviews] review requested: [Bug 111144] GIFImageReader to count frames and decode in one pass : [Attachment 192666] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 01:34:17 PDT 2013


Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 111144: GIFImageReader to count frames and decode in one pass
https://bugs.webkit.org/show_bug.cgi?id=111144

Attachment 192666: Patch
https://bugs.webkit.org/attachment.cgi?id=192666&action=review

------- Additional Comments from Hin-Chung Lam <hclam at google.com>
Thanks for Peter for the thorough review.

Major changes in the last patch:
* Fixed the problem of empty last frame. No more differences in the 60k images
corpus.
* Fixed two bugs uncovered by your review. Added a unit test to verify.
* Fixed the 3 bytes out of bound read.


More information about the webkit-reviews mailing list