[webkit-reviews] review granted: [Bug 111415] PDFPlugin: Make scrolling between pages in non-continuous modes work : [Attachment 192465] stylebot

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 111415: PDFPlugin: Make scrolling between pages in non-continuous modes
work
https://bugs.webkit.org/show_bug.cgi?id=111415

Attachment 192465: stylebot
https://bugs.webkit.org/attachment.cgi?id=192465&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192465&action=review


> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:90
> +static int defaultScrollMagnitudeThresholdForPageFlip = 20;

s/static/const/?

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:1010
> +	       [CATransaction begin];

I don't know why this is needed, taking on trust.