[webkit-reviews] review granted: [Bug 111956] PDFPlugin: Return PDFKit's data instead of the original resource data for save/etc. : [Attachment 192572] appease stylebot

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 111956: PDFPlugin: Return PDFKit's data instead of the original resource
data for save/etc.
https://bugs.webkit.org/show_bug.cgi?id=111956

Attachment 192572: appease stylebot
https://bugs.webkit.org/attachment.cgi?id=192572&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192572&action=review


> Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.h:75
> +    RetainPtr<NSData> liveData() const;
> +    RetainPtr<NSData> rawData() const { return (NSData *)m_data.get(); }

Looks like returning a pointer should work for both.

> Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.mm:689
> +    if (!m_pdfDocument)
> +	   return 0;

Is this check necessary?

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:909
> -	   return false;
> +	   return PassRefPtr<WebCore::SharedBuffer>();

My advice was probably not that good - the unimportant win in performance is
not worth it.