[webkit-reviews] review granted: [Bug 112059] Make SegmentedVector Noncopyable : [Attachment 192538] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 13:34:35 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 112059: Make SegmentedVector Noncopyable
https://bugs.webkit.org/show_bug.cgi?id=112059

Attachment 192538: Patch
https://bugs.webkit.org/attachment.cgi?id=192538&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192538&action=review


r=me

> Source/JavaScriptCore/bytecompiler/LabelScope.h:79
> +    struct LabelScopeRef {

Let's make this a class.

The idiomatic name for this in WebKit would be "LabelScopePtr".


More information about the webkit-reviews mailing list