[webkit-reviews] review granted: [Bug 111766] [CSS Exclusions] Refactor the ExclusionPolygon class to enable storing multiple boundaries : [Attachment 192480] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 111766: [CSS Exclusions] Refactor the ExclusionPolygon class to enable
storing multiple boundaries
https://bugs.webkit.org/show_bug.cgi?id=111766

Attachment 192480: Patch
https://bugs.webkit.org/attachment.cgi?id=192480&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192480&action=review


I am sorry. It took me a bit longer to review it. The patch looks great to me.
Just some snippets before landing.

> Source/WebCore/rendering/ExclusionPolygon.cpp:138
> +    for (unsigned i = 0; i < edges.size(); ++i)

I would keep the braces here, since the content of the for loop is more than a
line.

> Source/WebCore/rendering/ExclusionPolygon.h:40
>  #include "FloatPoint.h"
> +#include "FloatPolygon.h"
>  #include "FloatRect.h"
> -#include "PODIntervalTree.h"
>  #include "WindRule.h"
> -#include <wtf/MathExtras.h>
>  #include <wtf/OwnPtr.h>
>  #include <wtf/PassOwnPtr.h>

Can't your remove FloatPoint, FloatRect, WindRule, OwnPtr etc. dependencies
here? Should be included in FloatPolygon already.