[webkit-reviews] review granted: [Bug 111706] [WK2][EFL] Fix EwkContext class API : [Attachment 191974] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 10:56:49 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 111706: [WK2][EFL] Fix EwkContext class API
https://bugs.webkit.org/show_bug.cgi?id=111706

Attachment 191974: patch v2
https://bugs.webkit.org/attachment.cgi?id=191974&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191974&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:132
> +    static EwkContext* defaultInstance = 0;
> +    if (!defaultInstance)
> +	   defaultInstance = create().leakRef();

A better way to write this would be:

static EwkContext* defaultInstance = create().leakRef();


More information about the webkit-reviews mailing list