[webkit-reviews] review granted: [Bug 111918] [CSS Grid Layout] Handle spanning grid items over specified grid tracks : [Attachment 192332] Proposed change 1: Added a helper method to compute the spanned grid tracks' sizes.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 111918: [CSS Grid Layout] Handle spanning grid items over specified grid
tracks
https://bugs.webkit.org/show_bug.cgi?id=111918

Attachment 192332: Proposed change 1: Added a helper method to compute the
spanned grid tracks' sizes.
https://bugs.webkit.org/attachment.cgi?id=192332&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192332&action=review


> Source/WebCore/rendering/RenderGrid.cpp:750
> +	   // We don't support spanning with auto positions yet.

Nit: Should this be a FIXME?