[webkit-reviews] review denied: [Bug 111927] Style updates are not propagated to <use> elements after creation : [Attachment 192422] Patch

[bugzilla-daemon at webkit.org]

Stephen Chenney <schenney at chromium.org> has denied  review:
Bug 111927: Style updates are not propagated to <use> elements after creation
https://bugs.webkit.org/show_bug.cgi?id=111927

Attachment 192422: Patch
https://bugs.webkit.org/attachment.cgi?id=192422&action=review

------- Additional Comments from Stephen Chenney <schenney at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192422&action=review


Basically good. Just fix the build for SVG disabled. The EWS chromium bot
failure is a flake, not of any concern.

> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:31
> +#include "SVGElementInstance.h"

This needs to be protected with #if ENABLE(SVG)

> Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:403
> +	  
SVGElementInstance::invalidateAllInstancesOfElement(toSVGElement(m_parentElemen
t), false);

This also needs #if ENABLE(SVG) protection.