[webkit-reviews] review requested: [Bug 111435] [Qt][WK2] Specify storage paths through the C API : [Attachment 192457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 06:37:36 PDT 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has asked  for review:
Bug 111435: [Qt][WK2] Specify storage paths through the C API
https://bugs.webkit.org/show_bug.cgi?id=111435

Attachment 192457: Patch
https://bugs.webkit.org/attachment.cgi?id=192457&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
Added empty cache file path handling in PluginProcessProxyQt.cpp.
I'd prefer to keep the assert instead of handling an empty data location in
QtWebContext since it complexifies the code a lot more, and there is no way to
test this code, so I'd prefer to see if it is really needed before. From my
research in the QStandardPaths implementation, there should always be a
non-empty path returned for DataLocation and CacheLocation.


More information about the webkit-reviews mailing list