[webkit-reviews] review granted: [Bug 111965] Web Inspector: extract common parts of native profiles : [Attachment 192445] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 11 05:38:24 PDT 2013
Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 111965: Web Inspector: extract common parts of native profiles
https://bugs.webkit.org/show_bug.cgi?id=111965
Attachment 192445: Patch
https://bugs.webkit.org/attachment.cgi?id=192445&action=review
------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192445&action=review
> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:446
> + var metaInformation = /** @type{HeapSnapshotMetainfo}
*/(graphMetaInformation);
Whitespace in front of '(' (according to the code I've seen around)
> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:585
> + this.sidebarElement.subtitle = Number.bytesToString(/**
@type{number} */(this._memoryBlock.size));
ditto
More information about the webkit-reviews
mailing list